Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsconfig files to the appropriate repos #1070

Closed
samreid opened this issue Aug 6, 2021 · 7 comments
Closed

Add tsconfig files to the appropriate repos #1070

samreid opened this issue Aug 6, 2021 · 7 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Aug 6, 2021

For the feasibility prototype, tsconfig files have been aggregated in chipper. However, it is more appropriate to put the tsconfig files in the corresponding repos. I have avoided doing this until now since I didn't want to introduce any overhead or burden on JavaScript development. But @jonathanolson and I discussed it today, and think we can go ahead and do this. The only burden that we are aware of is that navigation in WebStorm will take you to the phet-types.d.ts file for assert/lodash/etc, instead of navigating to the files for those. But we realized that is also the long-term expected behavior.

@samreid samreid added this to the Basic Typescript Tooling milestone Aug 6, 2021
@samreid samreid self-assigned this Aug 6, 2021
@samreid
Copy link
Member Author

samreid commented Aug 6, 2021

In Slack, I said:

Do you think #1070 would be too disruptive to Fourier development?

@pixelzoom said:

I don’t know. Are you proposing to just add tsconfig files to each repo, or to turn on the new “TypeScript aware” build tools?

I replied:

Just the config files
Would it be OK if we add one or two, to make sure it doesn’t hamper JavaScript development? Then if it doesn’t hamper JavaScript development, we can add all of them?

@pixelzoom said:

Seems reasonable.

@samreid
Copy link
Member Author

samreid commented Sep 1, 2021

In the commits, I moved circuit construction kit common's tsconfig file to master. I'll use that for testing over the next few days (without typescript) to see if it hampers workflow in any way.

@samreid
Copy link
Member Author

samreid commented Sep 1, 2021

I worked with @zepumph on CCK with tsconfig in master for more than an hour and did not observe any problematic effects.

@samreid
Copy link
Member Author

samreid commented Sep 2, 2021

In discussion today, @jonathanolson advocated for combining tandem and axon repos, since they have so much crossover. I'm reluctant to do so--it seems there are some good separation of concerns and attempted modularity that would be good to keep.

But we agreed it is OK to start moving tsconfig files out to individual repos.

samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Sep 4, 2021
@samreid
Copy link
Member Author

samreid commented Sep 4, 2021

I can't get much further on #1073 without adding the tsconfig files to master, I'll start that soon.

samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-model-common that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-builder that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-model-introduction that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/acid-base-solutions that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/build-a-molecule that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/bending-light that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-model-algebra that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/area-model-decimals that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/balancing-act that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/arithmetic that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Sep 4, 2021
@samreid
Copy link
Member Author

samreid commented Sep 4, 2021

I've moved all the tsconfig to their corresponding repos. One note that these tsconfig files only include the core code for that repo, and not any of the tests. Tests often include downstream dependencies. For instance, the joist demo imports modules from sun and scenery-phet. So adding a dependency on joist means a dependency on joist but without its tests (and those transitive dependencies).

I'll open a new issue for how to do the test tsconfigs.

@samreid
Copy link
Member Author

samreid commented Sep 4, 2021

The tsconfig files have been moved to master. I tested some grunt output-js and grunt output-js-project and grunt output-js-all and they are working as expected. Closing.

@samreid samreid closed this as completed Sep 4, 2021
samreid added a commit to phetsims/circuit-construction-kit-ac-virtual-lab that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Sep 4, 2021
samreid added a commit that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/build-a-nucleus that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/build-an-atom that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/tandem that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/tandem that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/tandem that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/build-a-nucleus that referenced this issue Sep 4, 2021
samreid added a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant