-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsconfig files to the appropriate repos #1070
Comments
In Slack, I said:
@pixelzoom said:
I replied:
@pixelzoom said:
|
In the commits, I moved circuit construction kit common's tsconfig file to master. I'll use that for testing over the next few days (without typescript) to see if it hampers workflow in any way. |
I worked with @zepumph on CCK with tsconfig in master for more than an hour and did not observe any problematic effects. |
In discussion today, @jonathanolson advocated for combining tandem and axon repos, since they have so much crossover. I'm reluctant to do so--it seems there are some good separation of concerns and attempted modularity that would be good to keep. But we agreed it is OK to start moving tsconfig files out to individual repos. |
I can't get much further on #1073 without adding the tsconfig files to master, I'll start that soon. |
I've moved all the tsconfig to their corresponding repos. One note that these tsconfig files only include the core code for that repo, and not any of the tests. Tests often include downstream dependencies. For instance, the joist demo imports modules from sun and scenery-phet. So adding a dependency on joist means a dependency on joist but without its tests (and those transitive dependencies). I'll open a new issue for how to do the test tsconfigs. |
The tsconfig files have been moved to master. I tested some |
For the feasibility prototype, tsconfig files have been aggregated in chipper. However, it is more appropriate to put the tsconfig files in the corresponding repos. I have avoided doing this until now since I didn't want to introduce any overhead or burden on JavaScript development. But @jonathanolson and I discussed it today, and think we can go ahead and do this. The only burden that we are aware of is that navigation in WebStorm will take you to the phet-types.d.ts file for assert/lodash/etc, instead of navigating to the files for those. But we realized that is also the long-term expected behavior.
The text was updated successfully, but these errors were encountered: