Upgrade to ESLint 9 and flat config, see phetsims/chipper#1474

js/browser-tools/MultiSnapshotComparison.ts

@@ -1,5 +1,5 @@
 // Copyright 2022-2024, University of Colorado Boulder
-// eslint-disable-next-line bad-typescript-text
+// eslint-disable-next-line phet/bad-typescript-text
 // @ts-nocheck
 /**
  * Snapshot comparison across multiple running urls

js/browser-tools/take-snapshot.js

@@ -6,8 +6,7 @@
  *
  * @author Jonathan Olson <jonathan.olson@colorado.edu>
  */
-
-/* eslint-disable bad-phet-library-text */
+
 
 const options = QueryStringMachine.getAll( {
 

js/local/puppeteerHelpCT.js

@@ -14,7 +14,9 @@ process.on( 'SIGINT', () => process.exit() );
 ( async () => {
 
   assert( process.argv[ 2 ], 'usage: node puppeteerHelpCT {{SOME_IDENTIFIER_HERE}}' );
-  while ( true ) { // eslint-disable-line no-constant-condition
+
+  // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+  while ( true ) {
 
     await puppeteerLoad( `https://sparky.colorado.edu/continuous-testing/aqua/html/continuous-loop.html?id=localPuppeteer${process.argv[ 2 ]}`, {
       waitAfterLoad: 100000,

js/report/quickStatusProperty.js

@@ -16,7 +16,9 @@ const quickStatusProperty = new Property( {} );
 
 // Snapshot quick status loop
 ( async () => {
-  while ( true ) { // eslint-disable-line no-constant-condition
+
+  // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+  while ( true ) {
     const result = await request( '/quickserver/status' );
     if ( result ) {
       quickStatusProperty.value = result;

js/report/report.js

@@ -81,7 +81,9 @@ if ( options.full ) {
 
   // Report loop
   ( async () => {
-    while ( true ) { // eslint-disable-line no-constant-condition
+
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
       const result = await request( '/aquaserver/report' );
       if ( result ) {
         reportProperty.value = result;

js/report/statusProperty.js

@@ -20,7 +20,9 @@ const startupTimestampProperty = new NumberProperty( 0 );
 
 // Snapshot status loop
 ( async () => {
-  while ( true ) { // eslint-disable-line no-constant-condition
+
+  // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+  while ( true ) {
     const result = await request( '/aquaserver/status' );
     if ( result ) {
       statusProperty.value = result.status;

js/server/ContinuousServer.js

@@ -615,7 +615,9 @@ class ContinuousServer {
    * @public
    */
   async localTaskLoop() {
-    while ( true ) { // eslint-disable-line no-constant-condition
+
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
       try {
         if ( this.snapshots.length === 0 ) {
           await sleep( 1000 );
@@ -693,7 +695,9 @@ class ContinuousServer {
    * @public
    */
   async computeWeightsLoop() {
-    while ( true ) { // eslint-disable-line no-constant-condition
+
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
       try {
         this.computeRecentTestWeights();
       }
@@ -710,7 +714,9 @@ class ContinuousServer {
    * @public
    */
   async autosaveLoop() {
-    while ( true ) { // eslint-disable-line no-constant-condition
+
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
       try {
         this.saveToFile();
       }
@@ -726,7 +732,9 @@ class ContinuousServer {
    * @public
    */
   async generateReportLoop() {
-    while ( true ) { // eslint-disable-line no-constant-condition
+
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
       try {
         winston.info( 'Generating Report' );
         const testNameMap = {};

js/server/ContinuousServerClient.js

@@ -13,7 +13,7 @@
 const _ = require( 'lodash' );
 const path = require( 'path' );
 const assert = require( 'assert' );
-const { Worker } = require( 'worker_threads' ); // eslint-disable-line require-statement-match
+const { Worker } = require( 'worker_threads' ); // eslint-disable-line phet/require-statement-match
 const sleep = require( '../../../perennial/js/common/sleep' );
 
 process.on( 'SIGINT', () => process.exit( 0 ) );
@@ -89,7 +89,8 @@ class ContinuousServerClient {
     console.log( `ctID: ${this.ctID}` );
     console.log( `serverURL: ${this.serverURL}` );
 
-    while ( true ) { // eslint-disable-line no-constant-condition
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
 
       // Always keep this many workers chugging away
       while ( this.puppeteerWorkers.length < this.numberOfPuppeteers ) {

js/server/QuickServer.js

@@ -157,7 +157,8 @@ class QuickServer {
       browser: browser
     };
 
-    while ( true ) { // eslint-disable-line no-constant-condition
+    // TODO: What happened to no-constant-condition? See https://github.com/phetsims/chipper/issues/1451
+    while ( true ) {
 
       // Run the test, and let us know if we should wait for next test, or proceed immediately.
       await this.runQuickTest();

js/server/playwrightCTClient.js

@@ -8,7 +8,7 @@
 
 const assert = require( 'assert' );
 const playwrightLoad = require( '../../../perennial/js/common/playwrightLoad' );
-const { parentPort } = require( 'worker_threads' ); // eslint-disable-line require-statement-match
+const { parentPort } = require( 'worker_threads' ); // eslint-disable-line phet/require-statement-match
 const playwright = require( '../../../perennial/node_modules/playwright' );
 
 process.on( 'SIGINT', () => process.exit() );

js/server/puppeteerCTClient.js

@@ -9,7 +9,7 @@
 const assert = require( 'assert' );
 const path = require( 'path' );
 const puppeteerLoad = require( '../../../perennial/js/common/puppeteerLoad' );
-const { parentPort } = require( 'worker_threads' ); // eslint-disable-line require-statement-match
+const { parentPort } = require( 'worker_threads' ); // eslint-disable-line phet/require-statement-match
 
 process.on( 'SIGINT', () => process.exit() );
 

js/server/sendSlackMessage.js

@@ -8,7 +8,7 @@
 
 const buildLocal = require( '../../../perennial/js/common/buildLocal' );
 
-const { App } = require( '@slack/bolt' ); // eslint-disable-line require-statement-match
+const { App } = require( '@slack/bolt' ); // eslint-disable-line phet/require-statement-match
 
 let app;