Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lots of updates reflecting production requirements. #7

Closed
wants to merge 1 commit into from

Conversation

cuckon
Copy link

@cuckon cuckon commented Mar 10, 2019

pattern()和之前返回值不兼容,merge有风险,拒绝能理解:)

  • 新增了 * 的帧格式支持
  • 自动获取frames属性
  • 如果是序列,exists lexists isfile会判断序列结果
  • 更加简单的copy_sequence()调用形式
  • 不再对child()的参数进行检查(信任程序员)
  • 支持.bgeo.sc扩展名
  • pattern()返回的是Pattern(frame_pattern, padding_length)namedtuple
  • 小修正(excape()的re表达式等)

@cuckon cuckon closed this Mar 10, 2019
@phenom-films
Copy link
Collaborator

@cuckon
为什么close?很多特性很不错的

  • 新增了 * 的帧格式支持 (同意merge)
  • 自动获取frames属性 (考虑到硬盘性能问题,依旧交给用户判断)
  • 序列判断 exist 等,(考虑到情况很复杂,比如丢帧,会导致无法明确单一逻辑,不同意)
  • 更加简单的copy_sequence()调用形式 (待定)
  • 不再对child()的参数进行检查(信任程序员) (驳回,需要基础的防御)
  • 支持.bgeo.sc扩展名 (同意merge)
  • pattern() 应该是为了针对你的特定工作条件(暂时不接受)
  • 小修正(excape()的re表达式等) (请说明原有regex 出错的情况?)

@cuckon
Copy link
Author

cuckon commented Mar 13, 2019

base.py的diff识别有些问题,没法直接merge,另外这些修改倾向于在牺牲执行效率来提升开发效率,不一定适合所有情形,先close了。

  • 新加的”*“很依赖新的pattern()形式。
  • 原来re没有出错,只是把"(!|\$|#|&|\"|\'|\(|\)| |\||<|>||;)"换成了r"([!$#&"'() |<>;])"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants