Skip to content

fix: erratic file filter test fails #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: erratic file filter test fails #2444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/spec/FileFilters-integ-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,17 @@ define(function (require, exports, module) {
"", FileSystem));
await jsPromise(SpecRunnerUtils.createTextFile(`${testPathGitIgnore}/css/.gitignore`,
"foo.css", FileSystem));

// Wait for filesystem changes to propagate before opening search bar.
// When the search bar opens, it caches the file list (FindInFilesUI.js:242) by calling
// ProjectManager.getAllFiles() which performs gitignore filtering during directory traversal.
// We need to ensure gitignore files are fully written and filesystem events have propagated
// before this caching happens, otherwise the cached list won't respect the gitignore rules.
// Note: We tried awaitsFor() with various conditions (checking file readability, DocumentManager
// state, cache updates) but they were not reliable across all platforms.
// A 1-second delay is the most reliable approach for this test for now. @filefilter_delay_explanation
await awaits(1000);

await openSearchBar();

_setNoFilesExcluded();
Expand All @@ -503,6 +514,11 @@ define(function (require, exports, module) {
"bar.txt", FileSystem));
await jsPromise(SpecRunnerUtils.createTextFile(`${testPathGitIgnore}/css/.gitignore`,
"foo.css", FileSystem));

// Wait for filesystem changes to propagate before opening search bar. A 1-second delay is
// the most reliable approach for this test. See @filefilter_delay_explanation for explanation
await awaits(1000);

await openSearchBar();

_setNoFilesExcluded();
Expand Down
Loading