Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eforms module #44

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Conversation

jonatanprins
Copy link

PR for #42

Adds module for TED eForms.

@jonatanprins jonatanprins deleted the feat-add-eforms-module branch December 14, 2021 12:08
@phax
Copy link
Owner

phax commented Dec 14, 2021

Oh. Why this? I just wanted to merge it into the new eforms branch...

@jonatanprins
Copy link
Author

@phax sorry. Possibly should've been opened from a different account.

@phax
Copy link
Owner

phax commented Dec 14, 2021

Ah okay. As you like. I have no strong feelings who does it ;-)

@jonatanprins jonatanprins restored the feat-add-eforms-module branch December 14, 2021 13:34
@jonatanprins
Copy link
Author

We're ok. Branch restored.

@jonatanprins jonatanprins reopened this Dec 14, 2021
@phax phax changed the base branch from master to eforms December 14, 2021 13:41
@phax phax self-assigned this Dec 14, 2021
<packaging>bundle</packaging>
<name>ph-ubl-eforms</name>
<description>Library for reading and writing UBL eforms documents</description>
<url>https://github.com/phax/ph-ubl/ph-ubl</url>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last part should be ph-ubl-eforms

@phax
Copy link
Owner

phax commented Dec 14, 2021

@jonatanprins as soon as you remove the draft, I will merge it to a local branch in here

@jonatanprins jonatanprins marked this pull request as ready for review December 20, 2021 11:40
@phax phax merged commit 4c26d60 into phax:eforms Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants