Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMP lookup doesn't work properly #11

Merged
merged 1 commit into from
Apr 19, 2017
Merged

SMP lookup doesn't work properly #11

merged 1 commit into from
Apr 19, 2017

Conversation

pstetsuk
Copy link

SMP lookup doesn't work if ProcessIdentifier defined in uppercase on server
In the example the first smpClient.getEndpoint() returns the endpoind but the second call - returns null

@phax
Copy link
Owner

phax commented Apr 19, 2017

Hi Pavel!
This works as expected.
According to PEPPOL Policy for identifiers (see http://peppol.eu/downloads/?rel=tab87 - or https://joinup.ec.europa.eu/svn/peppol/TransportInfrastructure/PEPPOL_Policy%20for%20use%20of%20identifiers-300.pdf) the following applies:
POLICY 3: docType and process identifier values have to be treated case sensitive

@phax phax merged commit a1756d3 into phax:master Apr 19, 2017
@pstetsuk
Copy link
Author

Hi Philip!
Thank you for checking this out.

@phax
Copy link
Owner

phax commented Apr 19, 2017

No problem - your welcome.
In OASIS BDXR SMP this is handled slightly different.
When using the bdx-procid-transport process identifier scheme there, it will be handled case insensitive :)

@phax
Copy link
Owner

phax commented Apr 19, 2017

And the problem in this example is the uppercase document type ID - maybe I was telling this to Hatem by accident. Should be case sensitive (see POLICY 3)

@pstetsuk
Copy link
Author

Yes, but I think this is not a problem.

phax added a commit that referenced this pull request Apr 19, 2017
phax added a commit that referenced this pull request Apr 19, 2017
@phax
Copy link
Owner

phax commented Apr 19, 2017

I modified your code slightly - the uppercase document type ID should not work

@phax
Copy link
Owner

phax commented Apr 19, 2017

@pstetsuk pstetsuk deleted the case_insensitive_example branch April 19, 2017 12:37
@phax
Copy link
Owner

phax commented Apr 19, 2017

You're right but:
The overview at http://b-f7476450c0de81b01954e004dbd142c1.iso6523-actorid-upis.edelivery.tech.ec.europa.eu/iso6523-actorid-upis%3A%3A0088%3A5060510050006/ shows the lowercase URL!
We're getting closer....

@pstetsuk
Copy link
Author

Looks like the issue in SMP implementation

@phax
Copy link
Owner

phax commented Apr 19, 2017

I added an example DocType ID in uppercase and it is shown correctly:
http://test-infra.peppol.at/iso6523-actorid-upis%3A%3A9915%3Atest
(search for FOO).

@pstetsuk
Copy link
Author

I wrote before that this is not our SMP (I don't know which implementation they are using).
But now I have enough information for our support team.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants