Skip to content

Conversation

@glelouet
Copy link
Contributor

@glelouet glelouet commented Oct 3, 2025

Hello.

When I create a branch , then a PR, this branch is based on the version that was last when I branched. Let's say version A.

Later, the main repo master branch is released, and therefore given next version, version B.

If my PR incorporates new maven modules, those maven will be incorporated with version A on merging the PR, NOT with version B.

This means the tests on those modules will not take the recent changes into account. There may be bugs that won't be visible until a new release syncs the versions of those new module to a new one, say C.

This PR intend to avoid this :

  • on new PR accepted only on the main repo.
  • use the maven versions plugin to retrieve the root version and apply it to the sub modules
  • call mvn clean install . This is because the classes generated by the sub modules could have been created with older code and therefore differ on a new build. clean ensures an error is not considered a pass due to last classes still wroking.
  • if any change AND pass, git commit -am "post-process git" && git push

@glelouet
Copy link
Contributor Author

glelouet commented Oct 3, 2025

I did test on my master but this was not triggered. #sad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant