Skip to content

spine4.1 plugin about createSkeleton perf issue (also optimize spine plugin spineFileCallback func) #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2023
Merged

spine4.1 plugin about createSkeleton perf issue (also optimize spine plugin spineFileCallback func) #6344

merged 1 commit into from
Jan 15, 2023

Conversation

@justintien
Copy link
Contributor

@justintien justintien commented Jan 13, 2023

This PR

  • Fixes a bug

Describe the changes below:

  • [spine4.1] About SpinePlugin.createSkeleton func atlasPage.setTexture perf issue (Don't need setTexture for each time)
  • [spine] SpinePlugin.spineFileCallback also add 7th param settings. (Same with spine4.1)

@justintien justintien mentioned this pull request Jan 13, 2023
Open
1 task
@photonstorm photonstorm merged commit 288ec31 into phaserjs:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justintien @photonstorm