Add DOMElement#preRender, remove DOMElement#preUpdate #5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check parent visibility in preRender() Fixes phaserjs#5816
|
Sounds good to me. DOM Elements, the double-edge swords that never stop slicing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Removes
DOMElement#preUpdate()and replaces it withDOMElement #preRender(), for checking parent visibility. And DOMElement is no longer added to the scene update list.Purpose is to fix #5816 and improve DOMElement's visibility behavior. This way DOMElement will respond to its parent's visibility even if the scene is paused or DOMElement has
active = false.Fixes #5816