Skip to content

BREAKING CHANGE: use base64 encoding for data #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2023
Merged

BREAKING CHANGE: use base64 encoding for data #7

merged 3 commits into from
May 2, 2023

Conversation

@rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented May 2, 2023 •
edited
Loading

Description

Replaces hex encoding with base64 to optimize the size of ciphertext strings.

Changes

  • Updated the encryptString and decryptString utils to use b64 encoding / decoding instead of hex
  • Updated the regex in the tests to validate that the ciphertext is a base64 string
  • Bumped the package version to 2.0.0

@rohan-chaturvedi rohan-chaturvedi requested a review from nimish-ks May 2, 2023 10:35
@nimish-ks nimish-ks merged commit 6f1f207 into main May 2, 2023
@nimish-ks nimish-ks deleted the b64 branch May 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimish-ks nimish-ks nimish-ks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan-chaturvedi @nimish-ks