-
Notifications
You must be signed in to change notification settings - Fork 55
feat: app descriptions #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohan-chaturvedi
wants to merge
11
commits into
main
Choose a base branch
from
feat--app-description
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
39ebb6d
feat: ddd description field and migration to App model
rohan-chaturvedi ee54ad7
feat: add description field to AppType
rohan-chaturvedi 9e0045f
feat: add UpdateAppInfoMutation to update app details including name β¦
rohan-chaturvedi 6d3ee01
feat: add description field to UpdateAppInfo mutation and queries forβ¦
rohan-chaturvedi e8ed183
chore: regenerate graphql schema and types
rohan-chaturvedi 6616854
feat: implement AppDescriptionEditor and AppDescriptionViewer componeβ¦
rohan-chaturvedi 4c80b58
feat: add app description to app home
rohan-chaturvedi 1c024ca
fix: misc layout and ux improvements
rohan-chaturvedi b156887
refactor: hoist out markdown viewer, misc improvements to styling and ux
rohan-chaturvedi 352311d
feat: misc styling tweaks
rohan-chaturvedi 492fee3
Merge branch 'main' into feat--app-description
rohan-chaturvedi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Generated by Django 4.2.27 on 2026-02-03 10:03 | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('api', '0115_migrate_free_tier_to_v2_pricing'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='app', | ||
| name='description', | ||
| field=models.TextField(blank=True, null=True), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing validation for description length. Unlike the
namefield which has a maximum length validation (64 characters), thedescriptionfield has no length limit. This could potentially allow very large text inputs that may cause performance or storage issues. Consider adding a reasonable maximum length constraint (e.g., 10,000 or 50,000 characters) to prevent abuse.