Conversation
Contributor
|
Are the sounds already in this commit? because when I load the branch from git, the sounds are already included in here. So I have the same issues as on that other branch. Can you please confirm? |
Contributor
Author
they are, some of the bugfixes in the sounds PR was required for the cahnges in this one. Hence the dependency on #94 before merge |
5 tasks
tobelobb
approved these changes
Dec 14, 2025
Contributor
tobelobb
left a comment
There was a problem hiding this comment.
looks good, found no isuues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Depends On #94
When merged this pull request will:
Issue ticket number and link
Checklist before requesting a review