Merged
Conversation
Already defined some variables to build upon
Added deterministic environment behavior for units using an external RNG, including visibility, loss, and terrain slowdown calculations. Implemented registration, navigation bias, lost/bogged state management, and speed multiplier broadcasting. Integrated adapters and profiles for movement and visibility, and improved per-unit state handling.
Added implementations for environment speed multiplier, drift, repath request, and navigation bias setters/clearers. Also implemented path complexity calculation for units, providing normalized metrics based on path length and turns.
Added logic to sample_visibility_for_unit and sample_visibility_at to return visibility values based on unit position and renderer state. These methods now provide local visibility metrics for use in EnvBehaviorSystem.
Added signal connections and handlers for unit events (lost, recovered, bogged, unbogged) in the environment behavior system. Units are now paused or resumed based on these events. Also implemented navigation bias application and a helper for UID-to-index conversion.
Integrate drift application/clearing so lost/recovered units get movement drift updates via MovementAdapter.
pause and request engineer support on bogged units; log when road-biased moves are applied for easier debugging.
lost units now clear drift and repath when visibility, timeout, or friendly LOS allows; bogged transitions also trigger replanning.
parse common navigation-bias phrases into orders and attempt to assign engineer assistance when units bog down, logging the intent for visibility.
tune loss/bog heuristics with terrain/LOS recovery and stuck-soft escalation, apply env drift in movement, parse navigation-bias phrases, and emit radio/log feedback with engineer assistance hooks.
scale loss risk with behaviour, weather, terrain; recover when near landmarks or Hold/Regroup; retain existing drift/repath handling.
Contributor
Author
|
current state: many issues solved but the feature is still hard to test, which costs a lot of time so it'll take a few more days to finish |
Contributor
Author
|
the systems should now be working without crashing anything. Please review again so that I can revert the changes to the mission |
Tapawingo
approved these changes
Dec 12, 2025
Contributor
Tapawingo
left a comment
Tapawingo
left a comment
There was a problem hiding this comment.
This is very good. Remember to revert mission changes before merging :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Issue ticket number and link
Expand Unit Behaviour #48
Checklist before requesting a review