Skip to content

Hotfix/clipboard inspect bug#91

Merged
GianRathgeb merged 4 commits intomainfrom
hotfix/clipboard-inspect-bug
Nov 21, 2025
Merged

Hotfix/clipboard inspect bug#91
GianRathgeb merged 4 commits intomainfrom
hotfix/clipboard-inspect-bug

Conversation

@GianRathgeb
Copy link
Contributor

When merged this pull request will:

Dropping into the pause menu now safely releases any clipboard or tool the InteractionController was holding, whether you resume with ESC or the Resume button. The controller exposes a cancel_hold helper and joins an interaction_controllers group, and the pause menu uses that hook whenever it closes so dragging always works immediately after resuming.

Issue ticket number and link

No issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have tested my code.
  • I have documented my code in accordance with gdscript_documentation_comments.
  • I have requested a review in discord.
  • I have moved the related issues to the review section in the SCRUM Board.

Copy link
Contributor

@Tapawingo Tapawingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work. However, i think when the player left-clicks outside to stop inspecting the document it should return to a held state (like previously) instead of just being dropped directly from it's inspection position. This way the player can more easily organize their "workstation".

@GianRathgeb
Copy link
Contributor Author

Left-clicking or right-clicking outside an inspected clipboard now smoothly exits inspect mode without dropping it: left-click resumes the drag state so you can reposition immediately, while right-click keeps the previous behavior. Pressing ESC while inspecting still closes inspect, but it now explicitly drops the clipboard back onto the table to avoid re-entering drag mode when the pause menu opens.

Copy link
Contributor

@Tapawingo Tapawingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! approved.

@GianRathgeb GianRathgeb merged commit 404258c into main Nov 21, 2025
3 checks passed
@GianRathgeb GianRathgeb deleted the hotfix/clipboard-inspect-bug branch November 21, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants