Merged
Conversation
The issue still existed when the resume button was pressed
Tapawingo
requested changes
Nov 21, 2025
Contributor
Tapawingo
left a comment
There was a problem hiding this comment.
This seems to work. However, i think when the player left-clicks outside to stop inspecting the document it should return to a held state (like previously) instead of just being dropped directly from it's inspection position. This way the player can more easily organize their "workstation".
Contributor
Author
|
Left-clicking or right-clicking outside an inspected clipboard now smoothly exits inspect mode without dropping it: left-click resumes the drag state so you can reposition immediately, while right-click keeps the previous behavior. Pressing ESC while inspecting still closes inspect, but it now explicitly drops the clipboard back onto the table to avoid re-entering drag mode when the pause menu opens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Dropping into the pause menu now safely releases any clipboard or tool the InteractionController was holding, whether you resume with ESC or the Resume button. The controller exposes a cancel_hold helper and joins an interaction_controllers group, and the pause menu uses that hook whenever it closes so dragging always works immediately after resuming.
Issue ticket number and link
No issue
Checklist before requesting a review