Skip to content

Add configurable timeouts for sync:start. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Conversation

tekante
Copy link
Member

@tekante tekante commented Jul 21, 2017

Fixes #53

This sourced out of some troubleshooting with Mauricio where it took his machine quite a while to do the initial sync.

It occurs to me that maybe we should also allow for specification of this by environment variable since if someone needs this they probably need it the whole time. Especially since the sync:start will likely be getting trigged via an up alias in .outrigger.yml

Value: 10,
Usage: "Maximum amount of time in seconds to wait for the unison container to start",
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed about an environment variable.

Do we really have situations where both timeouts will be independently adjusted? Should we just have a --timeout flag and set the container start timeout to a percentage of the total timeout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sans a desire to detect an issue as soon as possible the answer is likely no. I've actually not seen anyone suffer from waiting for the container to start timing out, it was added as a function of "since I'm in here . . . "

@febbraro
Copy link
Member

Can we just set it via the outrigger.yml file?

@grayside
Copy link
Contributor

The need is for specific convoluted operations, projects with large codebases, and laptops with performance issues. Config file covers one of these

@febbraro
Copy link
Member

@grayside What do you mean "Config file covers one of these"

@grayside
Copy link
Contributor

Hit send too fast I suppose:

  1. Convoluted operations, such as moving the docroot aside and building a new one.
  2. Projects with large codebases, such that a build can pull in many, many files
  3. Laptops/hardware with performance issues, such that the need to support Unison might cause problems.

Of these, a config file driven approach to setting the timeout is really only routinely applicable to point 2. Point 1 is exception and would be better to set in the moment (perhaps even with an ignore-timeout sort of option), and point 3 is idiosyncratic to the individual, pointing to a need for a shell setting or an .outrigger.local.yml if it's to be set in a file.

@febbraro febbraro merged commit 011542e into develop Aug 8, 2017
@febbraro febbraro deleted the feature/sync-wait branch August 8, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants