Skip to content

Shouty errors - Highly verbose guidance when errors happen #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2018

Conversation

grayside
Copy link
Contributor

No description provided.

@febbraro
Copy link
Member

I really liked this, do you think it is good to merge?

@grayside
Copy link
Contributor Author

If the code looks good, go for it! Is RIG_POWER_USER_MODE and --power-user the flag we want? I was trying to think of a "stop yapping at me" toggle.

@febbraro
Copy link
Member

I think that power-user mode is fine for now. I'll have to see if the message bothers me. I was thinking initially that this message should only be part of verbose mode, but I'm guessing you considered that already.

@grayside
Copy link
Contributor Author

Yeah, it seems like the people that most need help don't think about doctor or verbose, which is why that is output in this message. It's almost an argument to hide this in verbose mode :)

Another idea I had was to have it show the full message only 3 times for a given error name, or per day, or the like, doing some state tracking via a home directory dotfile.

@febbraro
Copy link
Member

I say lets get it in, give as much info as possible and dial it back as needed if it is too much trouble (how could it be). Tools like npm are really loud when they fail.

@febbraro febbraro merged commit 1d8682f into develop Feb 27, 2018
@febbraro febbraro deleted the shouty-errors branch February 27, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants