Fixing Outrigger Dashboard on Linux #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
approved these changes
Nov 10, 2017
|
LOL. Because it is. Because I thought this would be outrigger-dashboard repo. |
…to wait for a 60 second timeout. Eeeek
grayside
reviewed
Nov 10, 2017
commands/doctor.go
Outdated
| cmd.out.Info.Printf("Docker Machine (%s) is running", cmd.machine.Name) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't this come before the docker-machine env checks above?
There was a problem hiding this comment.
Well, you have the ENV setup correctly, but the machine not started. The machine doesn't need to be started in order to test for that env configuration. I'm not against moving the check up a step though.
grayside
pushed a commit
that referenced
this pull request
Nov 11, 2017
* origin/develop: Display executed commands via Verbose Logging (#111) Better cross platform builds (#118) Fixing Outrigger Dashboard on Linux (#117) Fixed bug in libnss-resolver DNS resolution (#116) Added rpm to build, well, rpms Transitioned to different go base to try to head off problems with dynamically linked go binaries tweaking some build flags tweaking CGO messing with ldflags tweaked goreleaser config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.