Update dockerfile with pa11y-ci #7
Conversation
also removed some lines that are now included by default in the base alekzonder/puppeteer:1 image
| && mkdir -p /home/pptruser/Downloads \ | ||
| && chown -R pptruser:pptruser /home/pptruser \ | ||
| && chown -R pptruser:pptruser /screenshots \ | ||
| && chown -R pptruser:pptruser /usr/local/share/.config/yarn/global/node_modules |
There was a problem hiding this comment.
By dropping these permissions, can the pptuser still take screenshots?
There was a problem hiding this comment.
I believe so, but I have not tested the screenshot capability myself. These permissions are now included in the starting dockerfile here: https://hub.docker.com/r/alekzonder/puppeteer/~/dockerfile/
Dockerfile
Outdated
| && chown -R pptruser:pptruser /screenshots \ | ||
| && chown -R pptruser:pptruser /usr/local/share/.config/yarn/global/node_modules | ||
| RUN yarn global add pa11y@5 | ||
| RUN yarn global add pa11y-ci@2 |
There was a problem hiding this comment.
Can we have one of the following to minimize the number of layers?
RUN yarn global add pa11y@5 pa11y-ci@2
or
RUN yarn global add pa11y@5 && yarn global add pa11y-ci@2
Also, is it the case we need to explicitly add pa11y? We can't invoke it if it's a dependency of pa11y-ci?
There was a problem hiding this comment.
I have confirmed that pa11y needs to be explicitly added. If pa11y-ci gets added globally, that doesn't give access to pa11y globally
Dockerfile
Outdated
|
|
||
| USER pptruser | ||
|
|
||
| ENTRYPOINT ["dumb-init", "--", "pa11y"] | ||
| ENTRYPOINT ["dumb-init", "--"] |
There was a problem hiding this comment.
I like the flexibility here, but if we remove pa11y as part of the entrypoint, the -h flag in command will be an error.
I think we'll need to remove the CMD statement entirely.
This approach leaves us with:
docker run --rm outrigger/pa11y pa11y <url>
or
docker run --rm outrigger/pa11y pa11y-ci
a bit redundant, but we can work with that.
There was a problem hiding this comment.
From sidebar chat, maybe CMD should be "bash -c"?
also removed some lines that are now included by default in the base alekzonder/puppeteer:1 image