Skip to content

Fix 18328. Move asFileName method of String class to package Files#19853

Open
nsarfati wants to merge 1 commit into
pharo-project:Pharo15from
nsarfati:18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files
Open

Fix 18328. Move asFileName method of String class to package Files#19853
nsarfati wants to merge 1 commit into
pharo-project:Pharo15from
nsarfati:18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files

Conversation

@nsarfati

@nsarfati nsarfati commented Jul 5, 2026

Copy link
Copy Markdown

This PR fixes the next issue: #18328

Just move asFileName method of String class to package Files

@request-info

request-info Bot commented Jul 5, 2026

Copy link
Copy Markdown

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@nsarfati

nsarfati commented Jul 5, 2026

Copy link
Copy Markdown
Author

@pharo-ci done

@guillep

guillep commented Jul 5, 2026

Copy link
Copy Markdown
Member

I'll close and reopen so jenkins remerges the commits

@guillep guillep closed this Jul 5, 2026
@guillep guillep reopened this Jul 5, 2026
@Ducasse Ducasse closed this Jul 6, 2026
@Ducasse Ducasse reopened this Jul 6, 2026
@nsarfati
nsarfati force-pushed the 18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files branch from e7d80d6 to 2550ee7 Compare July 6, 2026 07:59
@nsarfati
nsarfati force-pushed the 18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files branch from 2550ee7 to 6f2b4ca Compare July 6, 2026 08:41
@Ducasse

Ducasse commented Jul 19, 2026

Copy link
Copy Markdown
Member

The bootstrap looks broken

+ /builds/workspace/est_and_branch_Pipeline_PR-19853/build/bootstrap-downloads/vmtarget/pharo --headless bootstrap.image
Initializing Collections
Initializing code model
Initializing sources
Initializing Session Manager
Initializing basic command line behaviorsInstance of Association did not understand #usingMethods
ByteSymbol(Symbol)>>handleDoesNotUnderstand:to:
Association(Object)>>doesNotUnderstand: 'usingMethods'
[ ] in UndeclaredRegistry>>verifyEmpty
Array(SequenceableCollection)>>collect:
UndeclaredRegistry>>verifyEmpty
PharoBootstrapInitialization class>>initializeCommandLine

@nsarfati

nsarfati commented Jul 25, 2026

Copy link
Copy Markdown
Author

Yes, seems moving the extension broke something else.

Next week I'll look on it and update the pull-request with the fix!

@Ducasse

Ducasse commented Jul 25, 2026

Copy link
Copy Markdown
Member

Tx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants