Fix 18328. Move asFileName method of String class to package Files#19853
Open
nsarfati wants to merge 1 commit into
Conversation
|
This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title. |
Author
|
@pharo-ci done |
Member
|
I'll close and reopen so jenkins remerges the commits |
nsarfati
force-pushed
the
18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files
branch
from
July 6, 2026 07:59
e7d80d6 to
2550ee7
Compare
nsarfati
force-pushed
the
18328-String--asFileName-should-be-packaged-with-FileSystem-Core-or-Files
branch
from
July 6, 2026 08:41
2550ee7 to
6f2b4ca
Compare
Member
|
The bootstrap looks broken |
Author
|
Yes, seems moving the extension broke something else. Next week I'll look on it and update the pull-request with the fix! |
Member
|
Tx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the next issue: #18328
Just move asFileName method of String class to package Files