Verify ephemeron key is not immediate when marking #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI is green, timed out in windows... |
PalumboN
reviewed
Apr 5, 2023
Comment on lines
+420
to
+435
| VMSpurOldSpaceGarbageCollectorTest >> testEphemeronWithImmediateKeyShouldNotFail [ | ||
|
|
||
| | ephemeron1 key | | ||
| ephemeron1 := self newEphemeronObjectWithSlots: 5. | ||
| self keepObjectInVMVariable1: ephemeron1. | ||
| key := memory integerObjectOf: 15. | ||
| memory storePointer: 0 ofObject: ephemeron1 withValue: key. | ||
|
|
||
| memory setCheckForLeaks: 63. "all" | ||
| memory fullGC. | ||
|
|
||
| self | ||
| assert: | ||
| (memory fetchInteger: 0 ofObject: self keptObjectInVMVariable1) | ||
| equals: 15 | ||
| ] |
Collaborator
There was a problem hiding this comment.
Why here the assertion says just 15 instead of key? @guillep
Member
Author
There was a problem hiding this comment.
I did a fetchInteger:, to make sure the same value is there.
What would be the most readable?
I think in any case we will need a comment, right?
Collaborator
There was a problem hiding this comment.
Ahhhh okkkkk. I don't think that a comment is needed, I just need to learn how to read 😅
Maybe having storeInteger: also would help with the symmetry.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ephemerons with immediate keys should not fail