Skip to content

Conversation

Copy link

Copilot AI commented Nov 13, 2025

Pull Request

The tlg/demographic.qmd file mixed traditional TLG examples (rtables/tern) with modern ARD-based examples (cards/gtsummary). This PR separates them into distinct sections for clearer navigation and enhanced documentation.

Changes

New cards/ section:

  • cards/index.qmd - Section landing page
  • cards/cards_demographic.qmd - Demographics table using {cards} and {gtsummary} packages for ARD-based workflows, with comprehensive introduction explaining CDISC Analysis Results Data (ARD) and the {cards} package

Updated tlg/demographic.qmd:

  • Removed gtsummary & cards content
  • Retained only rtables & tern examples
  • Updated introduction to reflect single approach
  • Added "See also" section with cross-reference link to CARDs demographic example

Configuration updates:

  • Added cards section to _quarto.yml sidebar (positioned after TLG)
  • Added 'cards' to inst/WORDLIST

Enhanced Documentation:

  • Added detailed introduction in cards/cards_demographic.qmd explaining CDISC Analysis Results Data (ARD) standard including benefits for reproducibility, automation, interoperability, and regulatory submissions
  • Added comprehensive description of the {cards} package and its key features
  • Provided clear context for ARD-based workflows demonstrated in examples
  • Added cross-reference from TLG to CARDs example for improved navigation

File Naming:

  • Renamed cards examples to cards_demographic.qmd and cards_demographic.R to avoid naming conflicts with TLG files (demographic.qmd and demographic.R)

The sidebar navigation now presents:

- sdtm
- adam
- tlg      (traditional tables/listings/graphs)
- cards    (ARD-based approaches)
- digit_files
- ...

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.
Original prompt

Separate the CARDs section from the TLG section


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits November 13, 2025 23:26
Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Copilot AI changed the title [WIP] Separate CARDs section from TLG section Separate CARDs section from TLG section Nov 13, 2025
Copilot AI requested a review from jeffreyad November 13, 2025 23:33
```

## Introduction

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more information about CDISC Analysis Results Data and {cards} package in the introduction

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Add more information about CDISC Analysis Results Data and {cards} package in the introduction at beginning of CARDs section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comprehensive information about CDISC Analysis Results Data and the {cards} package in the introduction. The enhanced introduction now includes:

  • A dedicated section explaining CDISC ARD with details on reproducibility, automation, interoperability, and regulatory submissions
  • A detailed description of the {cards} package highlighting its key features and capabilities
  • Clear context for the ARD-based workflow demonstrated in the examples

Commit: 2b25a94

…ation

Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
@jeffreyad
Copy link
Collaborator

@copilot rename the files in cards so they don't have the same name as the ones in TLGs, for example cards_demo

…flicts

Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 14, 2025

@copilot rename the files in cards so they don't have the same name as the ones in TLGs, for example cards_demo

Renamed the files in the cards directory to avoid naming conflicts:

  • demographic.qmdcards_demographic.qmd
  • demographic.Rcards_demographic.R

The TLG directory files remain as demographic.qmd and demographic.R.

Commit: 07b682d

@jeffreyad
Copy link
Collaborator

@copilot in the TLG section add a "See also" comment and link to CARDs example

Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 14, 2025

@copilot in the TLG section add a "See also" comment and link to CARDs example

Added a "See also" section at the end of tlg/demographic.qmd that links to the CARDs demographic example. The section provides context about the alternative ARD-based approach and includes a direct link to cards/cards_demographic.qmd.

Commit: 23165bc

@jeffreyad jeffreyad marked this pull request as ready for review November 14, 2025 18:26
@jeffreyad jeffreyad merged commit f0ef25a into 104_separate_out_cards Nov 14, 2025
1 check was pending
@jeffreyad jeffreyad deleted the copilot/separate-cards-from-tlg branch November 14, 2025 18:32
@bms63
Copy link
Collaborator

bms63 commented Nov 14, 2025

Haha do you even need us anymore Jeff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants