Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreIR] Make coreir an optional dependency #1312

Merged
merged 42 commits into from
Mar 11, 2024
Merged

[CoreIR] Make coreir an optional dependency #1312

merged 42 commits into from
Mar 11, 2024

Conversation

leonardt
Copy link
Collaborator

No description provided.

@leonardt leonardt requested a review from rsetaluri August 24, 2023 21:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.08%. Comparing base (3d1fb5d) to head (7128c5e).
Report is 1 commits behind head on master.

❗ Current head 7128c5e differs from pull request most recent head 4492cfb. Consider uploading reports for the commit 4492cfb to get more accurate results

Files Patch % Lines
magma/primitives/register.py 75.00% 2 Missing ⚠️
magma/util.py 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   85.09%   85.08%   -0.02%     
==========================================
  Files         169      169              
  Lines       17627    17637      +10     
==========================================
+ Hits        15000    15006       +6     
- Misses       2627     2631       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsetaluri rsetaluri changed the title Coreir optional [CoreIR] Make coreir an optional dependency Sep 23, 2023
@leonardt
Copy link
Collaborator Author

@rsetaluri this is ready for review now, I updated to be a minimal change that:

  • Removes the dependency from the setup.py
  • Updates the internals to only import coreir on demand (so importing magma doesn't fail when coreir isn't present)

I started down the road of updating the tests, but realized it might be simpler to just do a simple sanity check for the optional dependency for now (rather than updating the tests to skip coreir if it's not present, I think it's better to migrate or remove tests we don't want anymore in a follow up PR).

@leonardt leonardt merged commit 6c15b92 into master Mar 11, 2024
4 checks passed
@leonardt leonardt deleted the coreir-optional branch March 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants