-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreIR] Make coreir an optional dependency #1312
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
- Coverage 85.09% 85.08% -0.02%
==========================================
Files 169 169
Lines 17627 17637 +10
==========================================
+ Hits 15000 15006 +6
- Misses 2627 2631 +4 ☔ View full report in Codecov by Sentry. |
@rsetaluri this is ready for review now, I updated to be a minimal change that:
I started down the road of updating the tests, but realized it might be simpler to just do a simple sanity check for the optional dependency for now (rather than updating the tests to skip coreir if it's not present, I think it's better to migrate or remove tests we don't want anymore in a follow up PR). |
No description provided.