-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insights checker #28
base: master
Are you sure you want to change the base?
Conversation
i think better to use from client side directly, not to overload server |
@hbakhtiyor What do you mean, calling the Insights API? That shouldn't be very intensive.. @phanan What do you think? |
@barryvdh yeah, calling directly to Insights API |
Calling the API shouldn't be a problem. |
No indeed. But I meant, what do you think of the rest of the PR? |
Oh, sorry. Actually IMO breaking the insight results into individual items is a bit too much. I'd prefer using the score for the headline and the rest for expanded details. |
Also, why do we have two |
And sorry for not following up the repo very closely these days, I currently have lots of personal stuff to deal with :( |
Ah right, one should be ERROR indeed. We could be to just show the once that are failing, not all the green ones. Or perhaps add a different options to check using kupo rules, but also a check for Insights. The interface is very nice for it imho :) |
And no rush, take your time :) |
This adds https://github.com/dsentker/phpinsights by @dsentker and checks the Google Pagespeed Insights API for mobile and desktop, when the key is set.
It also shows the screenshots from mobile/desktop and the speed/usability scores.