-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration support for new columns #431
Conversation
Align stubs with real zephir methods requirements
Can you please add check for Phalcon version? Use new types if Phalcon >= 2.0.4 |
Of course. Will update this evening thanks. |
*/ | ||
const TYPE_LONGBLOB = 13; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this should be in ide/2.0.4/Phalcon/db/Column.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sergey, Should ONLY the Phalcon/db/Column.php file be committed under the 2.0.4 folder or should I make a full copy of the 2.0.0 folder and commit it all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for new column types implemented in Phalcon 2.0.4.
If you need IDE stubs with these column types you must generate stubs from Phalcon 2.0.x
branch:
zephir stubs
Phalcon DevTools contains IDE stubs in ide/<version>/Phalcon/
path.
After generating stubs for 2.0.4, you can commit them.
Sergey, The generated files should they be comitted against cphalcon repo or copied into the devetools/ide folder? The zephir stubs generated class.zep.php files? |
Or try to use Stub Generator |
The "stub generator" files were missing all the phpdoc comments on them? Have pushed the results using zephir stubs. |
Migration support for new columns
Thanks |
Adding migration support for new mysql columns added in main repo:
phalcon/cphalcon#10506