Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration support for new columns #431

Merged
merged 4 commits into from
Jun 23, 2015
Merged

Migration support for new columns #431

merged 4 commits into from
Jun 23, 2015

Conversation

mattvb91
Copy link
Contributor

Adding migration support for new mysql columns added in main repo:

phalcon/cphalcon#10506

@sergeyklay
Copy link
Contributor

Can you please add check for Phalcon version? Use new types if Phalcon >= 2.0.4

@mattvb91
Copy link
Contributor Author

Of course. Will update this evening thanks.

*/
const TYPE_LONGBLOB = 13;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this should be in ide/2.0.4/Phalcon/db/Column.php

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergey, Should ONLY the Phalcon/db/Column.php file be committed under the 2.0.4 folder or should I make a full copy of the 2.0.0 folder and commit it all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for new column types implemented in Phalcon 2.0.4.

If you need IDE stubs with these column types you must generate stubs from Phalcon 2.0.x branch:

zephir stubs

Phalcon DevTools contains IDE stubs in ide/<version>/Phalcon/ path.
After generating stubs for 2.0.4, you can commit them.

@andresgutierrez andresgutierrez changed the title Mattvb91/2.0.x Migration support for new columns Jun 17, 2015
@mattvb91
Copy link
Contributor Author

Sergey,

The generated files should they be comitted against cphalcon repo or copied into the devetools/ide folder? The zephir stubs generated class.zep.php files?

@sergeyklay
Copy link
Contributor

  1. Into devetools/ide folder like all other stubs.
  2. Yes, it seems Zephir generates *.zep.php files. For example you can rename the *.zep.php extension to *.php for a batch of files.

Or try to use Stub Generator

@mattvb91
Copy link
Contributor Author

The "stub generator" files were missing all the phpdoc comments on them? Have pushed the results using zephir stubs.

sergeyklay added a commit that referenced this pull request Jun 23, 2015
Migration support for new columns
@sergeyklay sergeyklay merged commit f78aaf1 into phalcon:2.0.x Jun 23, 2015
@sergeyklay
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants