fix issue in register form #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id of form was missing since bb7a972 So all the warnings have been shown on first start.
As in RegisterController.php shown at line 56 the field active is used as varchar and has "Y" as init value for new registered users. So either all the logic about active=="Y" must be replaced or my suggested fix is enough for people who are new at phalcon and trying to run this as part of phalcon-tutorials :o)
Minor change - Message same like in register-form + correction of utils.js for using same "#profileForm .alert" query to find alert tags
|
/cc @Jeckerson |
niden
approved these changes
Nov 29, 2022
|
This reverts some of the changes in the previous PR but will all be sorted out with the next PR. (I know confusing). Thank you @delphianer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id of form was missing since bb7a972
So all the warnings have been shown on first start.