Login form, Paginator & title fixes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aircodepl
changed the title
Codecov ReportBase: 6.24% // Head: 4.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
===========================================
- Coverage 6.24% 4.95% -1.29%
- Complexity 156 157 +1
===========================================
Files 31 32 +1
Lines 641 969 +328
===========================================
+ Hits 40 48 +8
- Misses 601 921 +320
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Jeckerson
approved these changes
Mar 27, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I've got some time to fix next issues. My goal is only help by fixing the project without making refactoring or code style decisions. So I'm trying to keep original ideas. At the end, I'll try to improve UI a bit.
get_title()withtitle()in the main layout to usetag->title()->set()parameters,PDO::ATTR_EMULATE_PREPARESto allow binding the same value to multiple conditions,tag->setDefault()doesn't exist, to allow filling login form with default user/password,There are more issues known, but I wish to split this job into a couple of small Pull Requests instead of one big. I hope it's ok.
@niden