Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Phalcon version to 5.1.4 for Docker, fix typos, remove duplicated migration queries #106

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

aircodepl
Copy link
Contributor

@aircodepl aircodepl commented Feb 8, 2023

Cosmetic changes to start with:

  • Updated Phalcon version to 5.1.4 for Docker,
  • Fixed 2 typos,
  • Removed duplicated migration queries which caused SQL errors

Through the next weeks, I'll try to fix this project to work with the Phalcon 5.x. Hope it's ok?

@aircodepl aircodepl changed the title Update Phalcon version to 5.1.4 for Docker & Fix typo Update Phalcon version to 5.1.4 for Docker, fix typos, remove duplicated migration queries Feb 8, 2023
@aircodepl
Copy link
Contributor Author

@niden Hi, I'm not 100% sure if removing these queries is the way to go.

If you could take a sec to look into that and merge or suggest the other way, I could move with the rest of the issues on the dedicated branch.

@niden
Copy link
Member

niden commented Feb 13, 2023

@aircodepl Lets remove them for now as you have done. Honestly I do not recall this code, so if that ends up being a mistake and we need it back then we can just re-add those methods.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 6.24% // Head: 6.24% // No change to project coverage 👍

Coverage data is based on head (c33fec7) compared to base (59acba7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #106   +/-   ##
========================================
  Coverage      6.24%   6.24%           
  Complexity      156     156           
========================================
  Files            31      31           
  Lines           641     641           
========================================
  Hits             40      40           
  Misses          601     601           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@niden niden merged commit fb57ee5 into phalcon:master Feb 13, 2023
@niden
Copy link
Member

niden commented Feb 13, 2023

Thank you @aircodepl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants