Skip to content

Commit

Permalink
#78 rename Memcached to Memcache
Browse files Browse the repository at this point in the history
This backend uses Memcache extension, not Memcached.
  • Loading branch information
Marcin Chwedziak committed Dec 30, 2013
1 parent 1284314 commit e169908
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
use Phalcon\Cache\Exception;

/**
* Class Memcached
* Class Memcache
*
* @package Phalcon\Cache\Backend\Memcache
* @package Phalcon\Cache\Backend
* @author Tobias Plaputta, Affinitas GmbH
* Released under the MIT license. http://nischenspringer.de/license
*/
class Memcached extends Backend implements BackendInterface
class Memcache extends Backend implements BackendInterface
{
const DEFAULT_HOST = '127.0.0.1';
const DEFAULT_PORT = 11211;
Expand All @@ -29,7 +29,7 @@ class Memcached extends Backend implements BackendInterface
protected $_memcache;

/**
* Phalcon\Cache\Backend\Memcache\Memcached constructor
* Phalcon\Cache\Backend\Memcache constructor
*
* @param \Phalcon\Cache\FrontendInterface $frontend
* @param array $options
Expand Down Expand Up @@ -326,4 +326,4 @@ public function isValid($keyName = null, $lifetime = null)
return ($this->exists($keyName, $lifetime) && $this->get($keyName, $lifetime));
}

}
}

2 comments on commit e169908

@Plaputta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah well, I had named it "Memcached" because Phalcon already has a Memcache Adapter, but Phalcon's implementation is very buggy. See phalcon/cphalcon#1550 - Renaming it to "Memcache" made endeveit delete it in commit 24e5d5b and now it's gone and we're left alone with the buggy version again :(

@Plaputta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great, didn't see that. Thanks!

Please sign in to comment.