ServiceProviderInterface add return type

[fagai]

I added it because an error will occur if you do not write the return value.

[sergeyklay]

@fagai Could you please explain a bit more the issue.

[fagai]

@sergeyklay

<?php

namespace App\Providers;

use Phalcon\Di\DiInterface;

class RouteServiceProvider implements \Phalcon\Di\ServiceProviderInterface
{
    public function register(DiInterface $di)
    {
          //
    }
}

$di->register(new \App\Providers\RouteServiceProvider);

Fatal error: Declaration of App\Providers\RouteServiceProvider::register(Phalcon\Di\DiInterface $di) must be compatible with Phalcon\Di\ServiceProviderInterface::register(Phalcon\Di\DiInterface $di): void in app/Providers/RouteServiceProvider.php on line 7

If you register the Service Provider as above, you will get an error with no return value.

[sergeyklay]

@fagai What version of Phalcon do you use?

[fagai]

@sergeyklay ver 4.0.5

[ruudboon]

If we merge this pull it will be overwritten on the next stubs generation. I think we need to fix this upstream, we can leave it open to track the issue but don't think it makes sense to merge it.

[fagai]

Now it's 4.1, but it didn't solve this problem.
It looks like void aren't taken into account when creating ide-stubs.

[fagai]

@ruudboon Since I had void support merged into the library, can I recreate the stub?

[Jeckerson]

Fixed in v5 versions. Closing.