Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use phalcon_is_iterable() macro instead of phalcon_is_iterable_ex() function #960

Merged
merged 3 commits into from Jul 31, 2013
Merged

Use phalcon_is_iterable() macro instead of phalcon_is_iterable_ex() function #960

merged 3 commits into from Jul 31, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2013

The macro was updated to restore the memory frame and the function was modified not to touch memory frames. This allows to use phalcon_is_iterable_ex() function in the kernel code where memory frames are avoided to boost performance.

Now that phalcon_is_iterable_ex() became smaller, it has more chances to be inlined when used in the kernel code.

phalcon pushed a commit that referenced this pull request Jul 31, 2013
Use phalcon_is_iterable() macro instead of phalcon_is_iterable_ex() function
@phalcon phalcon merged commit 63886a2 into phalcon:1.3.0 Jul 31, 2013
@ghost ghost deleted the phalcon_is_iterable branch July 31, 2013 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants