Mix integer and string placeholders in Phalcon\Mvc\Model\Query\Builder

[ghost]

See #701

[jeffreycahyono]

Wow that was fast, Thanks. I hope it can be merged into 1.2.1 branch as well :)

[ghost]

If you are familiar with patches and git and can build phalcon yourself, you can just apply this patch to 1.2.1:

diff --git a/ext/mvc/model/query/builder.c b/ext/mvc/model/query/builder.c
index 6b7620f..8cc70a9 100644
--- a/ext/mvc/model/query/builder.c
+++ b/ext/mvc/model/query/builder.c
@@ -562,7 +562,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, where){
        phalcon_read_property_this(&current_bind_params, this_ptr, SL("_bindParams"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_params) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_params);
-           phalcon_fast_array_merge(merged_params, &current_bind_params, &bind_params TSRMLS_CC);
+           phalcon_add_function(merged_params, bind_params, current_bind_params TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_params, bind_params);
        }
@@ -579,7 +579,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, where){
        phalcon_read_property_this(&current_bind_types, this_ptr, SL("_bindTypes"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_types) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_types);
-           phalcon_fast_array_merge(merged_types, &current_bind_types, &bind_types TSRMLS_CC);
+           phalcon_add_function(merged_params, bind_types, current_bind_types TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_types, bind_types);
        }
@@ -646,7 +646,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, andWhere){
        phalcon_read_property_this(&current_bind_params, this_ptr, SL("_bindParams"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_params) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_params);
-           phalcon_fast_array_merge(merged_params, &current_bind_params, &bind_params TSRMLS_CC);
+           phalcon_add_function(merged_params, bind_params, current_bind_params TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_params, bind_params);
        }
@@ -663,7 +663,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, andWhere){
        phalcon_read_property_this(&current_bind_types, this_ptr, SL("_bindTypes"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_types) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_types);
-           phalcon_fast_array_merge(merged_types, &current_bind_types, &bind_types TSRMLS_CC);
+           phalcon_add_function(merged_params, bind_types, current_bind_types TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_types, bind_types);
        }
@@ -730,7 +730,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, orWhere){
        phalcon_read_property_this(&current_bind_params, this_ptr, SL("_bindParams"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_params) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_params);
-           phalcon_fast_array_merge(merged_params, &current_bind_params, &bind_params TSRMLS_CC);
+           phalcon_add_function(merged_params, bind_params, current_bind_params TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_params, bind_params);
        }
@@ -747,7 +747,7 @@ PHP_METHOD(Phalcon_Mvc_Model_Query_Builder, orWhere){
        phalcon_read_property_this(&current_bind_types, this_ptr, SL("_bindTypes"), PH_NOISY_CC);
        if (Z_TYPE_P(current_bind_types) == IS_ARRAY) { 
            PHALCON_INIT_VAR(merged_types);
-           phalcon_fast_array_merge(merged_types, &current_bind_types, &bind_types TSRMLS_CC);
+           phalcon_add_function(merged_types, bind_types, current_bind_types TSRMLS_CC);
        } else {
            PHALCON_CPY_WRT(merged_types, bind_types);
        }

and recompile Phalcon :-)