Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/fcall.c optimizations #843

Merged
merged 23 commits into from Jul 15, 2013
Merged

kernel/fcall.c optimizations #843

merged 23 commits into from Jul 15, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2013

Features:

  • removed duplicated code
  • removed noreturn parameter (return_value == NULL when the caller does not want the return value) — less arguments => more opportunities for inlining
  • reorganized macros in kernel/fcall.h a bit (for readability)
  • removed not used code

Unrelated but required changes:

  • fix spurious segfaults in kernel/string.c due to not initialized use_copy
  • updated php_phalcon.h in build/
  • added missing headers/sources to gen-build.php
  • instructed gen-build.php not to strip system headers

phalcon pushed a commit that referenced this pull request Jul 15, 2013
kernel/fcall.c optimizations
@phalcon phalcon merged commit e29a21a into phalcon:1.2.1 Jul 15, 2013
@ghost ghost deleted the fcall branch July 16, 2013 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants