Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2002 Tag::linkTo() to allow the addition of query string parameters #2054

Closed
wants to merge 5 commits into from
Closed

Conversation

dreamsxin
Copy link
Contributor

See #2002

echo Phalcon\Tag::linkTo(array('signup/register', 'Register Here!', 'query' => array('a' => 1, 'b' => 2)))
<a href="/signup/register?a=1&b2">Register Here!</a>

@phalcon
Copy link
Collaborator

phalcon commented Feb 18, 2014

I think those query arguments must be passed to the url service: https://github.com/phalcon/cphalcon/blob/master/ext/mvc/url.c#L269

@dreamsxin
Copy link
Contributor Author

You are right

@niden
Copy link
Member

niden commented Mar 19, 2014

@dreamsxin Can you please issue the PR to the 1.3.2 branch?

@dreamsxin dreamsxin closed this Mar 28, 2014
@dreamsxin dreamsxin deleted the nfr2002 branch April 15, 2014 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants