Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16441 tag factory reset #16455

Merged
merged 12 commits into from
Oct 24, 2023
Merged

T16441 tag factory reset #16455

merged 12 commits into from
Oct 24, 2023

Conversation

niden
Copy link
Member

@niden niden commented Oct 24, 2023 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Html\Helper\AbstractSeries::__invoke() to no longer clear the internal store when called
Added Phalcon\Html\Helper\AbstractSeries::reset() to clear the internal store when needed

Thanks

@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Oct 24, 2023
@niden niden requested a review from Jeckerson October 24, 2023 15:38
@niden niden self-assigned this Oct 24, 2023
@niden niden changed the base branch from master to 5.0.x October 24, 2023 15:39
@niden niden added bug A bug report status: medium Medium labels Oct 24, 2023
@niden niden linked an issue Oct 24, 2023 that may be closed by this pull request
[BUG]: TagFactory __invoke and Html\Helper\Meta,Link,Script,Style. Store reset at each call #16441
Closed
@niden niden merged commit 24d225d into phalcon:5.0.x Oct 24, 2023
38 checks passed
@niden niden deleted the T16441-tag-factory-reset branch October 24, 2023 19:07
@niden niden mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: TagFactory __invoke and Html\Helper\Meta,Link,Script,Style. Store reset at each call
2 participants
@niden @Jeckerson