Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16396 jwt addheader #16397

Merged
merged 8 commits into from
Aug 10, 2023
Merged

T16396 jwt addheader #16397

merged 8 commits into from
Aug 10, 2023

Conversation

niden
Copy link
Member

@niden niden commented Aug 9, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added Phalcon\Encryption\Security\JWT\Builder::addHeader() to allow adding custom headers

Thanks

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Aug 9, 2023
@niden niden requested a review from Jeckerson August 9, 2023 22:43
@niden niden self-assigned this Aug 9, 2023
@niden niden changed the base branch from master to 5.0.x August 9, 2023 22:43
@niden niden linked an issue Aug 9, 2023 that may be closed by this pull request
[NFR] Add/manage custom headers in JWT Token #16396
Closed
@niden niden merged commit 686960d into phalcon:5.0.x Aug 10, 2023
@niden niden deleted the T16396-jwt-addheader branch August 10, 2023 13:49
@niden niden mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR] Add/manage custom headers in JWT Token
2 participants
@niden @Jeckerson