Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T16255 reflection getclass #16257

Merged
merged 9 commits into from
Jan 10, 2023
Merged

T16255 reflection getclass #16257

merged 9 commits into from
Jan 10, 2023

Conversation

niden
Copy link
Member

@niden niden commented Jan 10, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Acl\Adapter\Memory::isAllowed to not use the deprecated ReflectionType::getClass

Thanks

@niden niden added status: high High 5.0 The issues we want to solve in the 5.0 release labels Jan 10, 2023
@niden niden requested a review from Jeckerson January 10, 2023 15:37
@niden niden self-assigned this Jan 10, 2023
@niden niden merged commit 7d617db into phalcon:5.0.x Jan 10, 2023
@niden niden deleted the T16255-reflection-getclass branch January 10, 2023 19:08
@daaquan
Copy link

daaquan commented Jan 19, 2023

Hello,

Phalcon\Mvc\Model\Binder class seems to have the same problem.

let reflectionClass = methodParam->getClass();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release status: high High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants