T15977 gd webm 2 #16044

niden · 2022-08-05T17:34:19Z

Hello!

Type: bug fix
Link to issue: [BUG]: GD with enabled webp support, but still return error #15977

In raising this pull request, I confirm the following:

I have read and understood the Contributing Guidelines
I have checked that another pull request for this purpose does not exist
I wrote some tests for this PR
I have updated the relevant CHANGELOG
I have created a PR for the documentation about this change

Reorganized code in the image adapters
Simplified various areas, speeding up processing
Removed getInternalImImage() (same as getImage()) for Phalcon\Image\Adapter\Imagick
Added better support for webm images

Thanks

niden self-assigned this Aug 5, 2022

niden requested a review from Jeckerson August 5, 2022 17:34

niden added 5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request bug A bug report labels Aug 5, 2022

niden linked an issue Aug 5, 2022 that may be closed by this pull request

[BUG]: GD with enabled webp support, but still return error #15977

Closed

niden added 6 commits August 5, 2022 16:17

[#15977] - added assets for image tests

b6428bc

[#15977] - reworked the image tests

a01ebea

[#15977] - renaming of new assets

b3dbced

[#15977] - corrections, optimizations, sync with phalcon and webm

ff53eee

[#15977] - docblock corrections

0ad96f6

updating changelog

1ac2f1e

Jeckerson approved these changes Aug 6, 2022

View reviewed changes

niden merged commit 2997c82 into phalcon:5.0.x Aug 8, 2022

niden deleted the T15977-gd-webm-2 branch August 8, 2022 12:53

niden mentioned this pull request Aug 8, 2022

[BUG]: GD with enabled webp support, but still return error #15977

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T15977 gd webm 2 #16044

T15977 gd webm 2 #16044

niden commented Aug 5, 2022

T15977 gd webm 2 #16044

T15977 gd webm 2 #16044

Conversation

niden commented Aug 5, 2022