[BUG] Complex Resultset double unserializing #16036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALameLlama
changed the title
|
This will fail in PHP8.1. As there are no tests against |
|
@Jeckerson I think the new changes made to this PR should work with both 7.4-8.0 and 8.1 |
This was
linked to
issues
Oct 14, 2022
Jeckerson
added
bug
Jeckerson
approved these changes
Oct 14, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
This fixes the double unserializing in the complex resultset, the function
__unserialize(array data)takes an array and tries to unserialize it again, this can be removed since it's already unserialized by this pointI've also cleaned up the function
serializeto have a data variableThanks