T15977 gd webm #16027

niden · 2022-07-19T20:53:23Z

Hello!

Type: bug fix
Link to issue: [BUG]: GD with enabled webp support, but still return error #15977

In raising this pull request, I confirm the following:

I have read and understood the Contributing Guidelines
I have checked that another pull request for this purpose does not exist
I wrote some tests for this PR
I have updated the relevant CHANGELOG
I have created a PR for the documentation about this change

Fixed rendering for webp images for Phalcon\Image\Adapter\Gd

Thanks

niden · 2022-08-05T16:30:36Z

Incorrect implementation

niden added 5 commits July 19, 2022 16:51

[#15977] - added more assets for image tests

92df99f

[#15977] - renamed image files for testing

fe2badc

[#15977] - fixed webm, wbmp and xdm detection and rendering

27c9ba0

[#15977] - corrected and enhanced tests

6d3d717

[#15977] - updating changelog

4933836

niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jul 19, 2022

niden requested a review from Jeckerson July 19, 2022 20:53

niden self-assigned this Jul 19, 2022

niden linked an issue Jul 19, 2022 that may be closed by this pull request

[BUG]: GD with enabled webp support, but still return error #15977

Closed

niden added 5 commits July 19, 2022 17:13

[#15977] - adding more debugging to diagnose segfault

3e25d00

[#15977] - more debugging

6117141

[#15977] - disabling image render test

98af037

[#15977] - more test adjustments

017c664

[#15977] - disabling image/render test again

36817e9

niden closed this Aug 5, 2022

niden deleted the T15977-gd-webm branch August 5, 2022 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T15977 gd webm #16027

T15977 gd webm #16027

niden commented Jul 19, 2022

niden commented Aug 5, 2022

T15977 gd webm #16027

T15977 gd webm #16027

Conversation

niden commented Jul 19, 2022

niden commented Aug 5, 2022