Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15977 gd webm #15989

Merged
merged 5 commits into from
Jun 10, 2022
Merged

T15977 gd webm #15989

merged 5 commits into from
Jun 10, 2022

Conversation

niden
Copy link
Member

@niden niden commented Jun 10, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added support for webp images for Phalcon\Image\Adapter\Gd

Thanks

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Jun 10, 2022
@niden niden requested a review from Jeckerson June 10, 2022 13:02
@niden niden self-assigned this Jun 10, 2022
@niden niden linked an issue Jun 10, 2022 that may be closed by this pull request
[BUG]: GD with enabled webp support, but still return error #15977
Closed
@niden niden merged commit 02f0f5f into phalcon:5.0.x Jun 10, 2022
@niden niden deleted the T15977-gd-webm branch June 10, 2022 15:42
@niden niden mentioned this pull request Jun 10, 2022
Closed
@borisdelev
Copy link
Contributor

@niden can you check again that format is supported, because ive get error in RC3 too? Sorry!

@niden
Copy link
Member Author

niden commented Jul 19, 2022

@borisdelev Can you send me your webm file if you can please (team@phalcon.io). The test I wrote in this PR I got it from the internet.

@borisdelev
Copy link
Contributor

borisdelev commented Jul 19, 2022 •
edited
Loading

@niden Done. Thanks again for double check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: GD with enabled webp support, but still return error
3 participants
@niden @borisdelev @Jeckerson