Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15904 cache #15923

Merged
merged 12 commits into from
Mar 16, 2022
Merged

T15904 cache #15923

merged 12 commits into from
Mar 16, 2022

Conversation

niden
Copy link
Member

@niden niden commented Mar 15, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Session\Bag::__construct() to accept a Phalcon\Session\Manager as the first parameter and name as the second one
Fixed Phalcon\Storage\Adapter\* to correctly store null values
Added Phalcon\Storage\Serializer\MemcachedIgbinary, Phalcon\Storage\Serializer\MemcachedJson, Phalcon\Storage\Serializer\MemcachedPhp, Phalcon\Storage\Serializer\RedisIgbinary, Phalcon\Storage\Serializer\RedisJson, Phalcon\Storage\Serializer\RedisMsgpack, Phalcon\Storage\Serializer\RedisNone, Phalcon\Storage\Serializer\RedisPhp to be used if adapter serialization is required

Thanks

@niden niden added breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Mar 15, 2022
@niden niden requested a review from Jeckerson March 15, 2022 21:49
@niden niden self-assigned this Mar 15, 2022
@niden niden linked an issue Mar 15, 2022 that may be closed by this pull request
[BUG]: Cache\AdapterFactory - Get Key with value of zero returns NULL #15904
Closed
@Jeckerson
Copy link
Member

Jeckerson commented Mar 15, 2022 •
edited
Loading

Some errors in closures, did you generated latest Zephir code?

@niden
Copy link
Member Author

niden commented Mar 15, 2022

Some errors in closures, did you generated latest Zephir code?

I did ... odd

@Jeckerson
Copy link
Member

Great job!

@niden niden merged commit f7b78db into phalcon:5.0.x Mar 16, 2022
@niden niden deleted the T15904-cache-2 branch March 16, 2022 18:02
@niden niden mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Cache\AdapterFactory - Get Key with value of zero returns NULL
2 participants
@niden @Jeckerson