Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed support/collection/readonly to support/collection/readonlycol… #15768

Merged
merged 3 commits into from
Nov 7, 2021
Merged

renamed support/collection/readonly to support/collection/readonlycol… #15768

merged 3 commits into from
Nov 7, 2021

Conversation

niden
Copy link
Member

@niden niden commented Nov 6, 2021

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Support\Collection\ReadOnly to Phalcon\Support\Collection\ReadOnlyCollection to avoid conflicts with the read-only feature in PHP 8.1

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Nov 6, 2021
@niden niden requested a review from Jeckerson November 6, 2021 17:35
@niden niden self-assigned this Nov 6, 2021
@niden niden linked an issue Nov 6, 2021 that may be closed by this pull request
[BUG]: Rename \Phalcon\Support\Collection\Readonly for PHP 8.1 support #15767
Closed
@niden niden merged commit a12f46f into phalcon:5.0.x Nov 7, 2021
@niden niden deleted the T15767-readonly-php-81 branch November 7, 2021 20:05
@niden niden mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Rename \Phalcon\Support\Collection\Readonly for PHP 8.1 support
2 participants
@niden @Jeckerson