Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default di in getDI() #15629

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Set default di in getDI() #15629

merged 3 commits into from
Aug 21, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Aug 20, 2021 •
edited by niden
Loading

Hello!

  • Type: code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Related: #15629
Credit: https://github.com/stijn1989

Thanks

@Jeckerson Jeckerson added enhancement Enhancement to the framework 5.0 The issues we want to solve in the 5.0 release labels Aug 20, 2021
@Jeckerson Jeckerson requested a review from niden August 20, 2021 20:05
@Jeckerson Jeckerson self-assigned this Aug 20, 2021
@Jeckerson Jeckerson mentioned this pull request Aug 20, 2021
Closed
5 tasks
@niden niden merged commit d980f39 into 5.0.x Aug 21, 2021
@niden niden deleted the set-default-di branch August 21, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @niden