-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests stubs for ViewSimple #1560
Conversation
Is everything allright with travis? |
A segfault is happening: Core was generated by `/home/travis/.phpenv/versions/5.3.3/bin/php ./unit-tests/ci/phpunit.php --debug'.
Program terminated with signal 11, Segmentation fault.
#0 0x0000000000818c4e in gc_zval_possible_root (zv=0x5ba3c70,
tsrm_ls=0x2475310) at /tmp/php-build/source/5.3.3/Zend/zend_gc.c:143
143 /tmp/php-build/source/5.3.3/Zend/zend_gc.c: No such file or directory.
(gdb) (gdb) #0 0x0000000000818c4e in gc_zval_possible_root (zv=0x5ba3c70, tsrm_ls=0x2475310) at /tmp/php-build/source/5.3.3/Zend/zend_gc.c:143
No locals.
#1 0x0000000000806d48 in zend_hash_destroy (ht=0x5b72b90) at /tmp/php-build/source/5.3.3/Zend/zend_hash.c:526
p = 0x5bb34d0
q = 0x5bb3468
#2 0x000000000081a0d9 in zend_object_std_dtor (object=0x5baf648, tsrm_ls=<optimized out>) at /tmp/php-build/source/5.3.3/Zend/zend_objects.c:45
No locals.
#3 0x000000000081a0f9 in zend_objects_free_object_storage (object=0x5baf648, tsrm_ls=<optimized out>) at /tmp/php-build/source/5.3.3/Zend/zend_objects.c:128
No locals.
#4 0x000000000081e4c5 in zend_objects_store_del_ref_by_handle_ex (handle=2669, handlers=<optimized out>, tsrm_ls=0x2475310) at /tmp/php-build/source/5.3.3/Zend/zend_objects_API.c:220
__orig_bailout = 0x7fffa356b2b0
__bailout = {{__jmpbuf = {96107536, -4550680150059536115, 0, 0, 0, 0, 4550885913217446157, -4550683949451726579}, __mask_was_saved = 0, __saved_mask = {__val = {13896063923650015501, 0, 0, 0, 0, 4550885913192280333, 13896060124257825037, 0, 7949371, 96050088, 8222102, 96050064, 7949371, 0, 7949371, 96050024}}}}
obj = 0x5713778
failure = <optimized out>
#5 0x000000000081e4fe in zend_objects_store_del_ref (zobject=0x5ba7c10, tsrm_ls=0x2475310) at /tmp/php-build/source/5.3.3/Zend/zend_objects_API.c:172 |
This looks like a bug in View\Simple. |
|
|
||
public function testMissingView() | ||
{ | ||
$this->setExpectedException('Exception'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPUnit 3.6.10 throws an exception here:
InvalidArgumentException: You must not expect the generic exception class.
The correct syntax will be
$this->setExpectedException('Phalcon\Mvc\View\Exception');
The test script outputs |
Yes, output |
Could you please merge this PR against current 1.3.0? |
…s-viewsimple Conflicts: unit-tests/TODO.txt
I've only heard about random segfaults on travis with PHP but first time really see it happening. |
Segfault is addressed in #1607 |
This PR is for testing Phalcon\Mvc\View\Simple
Could you pls check if I'm doing caching correctly?
Only tested on Phalcon 1.3.0 atm, will do 2.0.0 soon