Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session issue 14694 #14759

Merged
merged 7 commits into from
Jan 23, 2020
Merged

Fix session issue 14694 #14759

merged 7 commits into from
Jan 23, 2020

Conversation

ruudboon
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
During writing we lock the file and during reading we wait for the file to be unlocked.

@ruudboon ruudboon added the 4.0.3 label Jan 22, 2020
@niden niden added bug A bug report status: medium Medium labels Jan 22, 2020
Copy link
Member

@niden niden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. If tests pass ci-skip the change and this is ready to merge

phalcon/Session/Adapter/Stream.zep Outdated Show resolved Hide resolved
phalcon/Storage/Adapter/Stream.zep Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #14759 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14759      +/-   ##
==========================================
- Coverage   67.99%   67.99%   -0.01%     
==========================================
  Files         483      483              
  Lines      111464   111463       -1     
==========================================
- Hits        75787    75786       -1     
  Misses      35677    35677

@ruudboon ruudboon requested a review from niden January 23, 2020 06:09
Jeckerson
Jeckerson previously approved these changes Jan 23, 2020
@niden niden merged commit bf85ce6 into phalcon:4.0.x Jan 23, 2020
@ruudboon ruudboon deleted the fix-session-issue-14694 branch February 4, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants