Faster version of Phalcon\DI using object handlers

[ghost]

No description provided.

[dreamsxin]

+1

[phalcon]

I'm completely sure that this would be faster than the current DI, but it would be hard to produce similar code in Zephir

[ghost]

We can try. Object handlers are actually not that difficult.

Just take a look at this gist: https://gist.github.com/sjinks/5954372

I think we can start with basic implementation of __get(), __set(), __unset(), __isset(), offsetGet(), offsetSet(), offsetUnset(), offsetExists() via object handlers. This won't be as fast as the current code that uses object handlers, but still will be several times faster than the code that does not use object handlers.

Object handlers will look like this:

static void phalcon_di_write_dimension(zval *object, zval *offset, zval *value TSRMLS_DC)
{
    if (Z_OBJCE_P(object) != phalcon_di_ce) {
        /* Honor inheritance */
        zend_get_std_object_handlers()->write_dimension(object, offset, value TSRMLS_CC);
        return;
    }

    /* Here goes the code from the original offsetSet() */

    /* If offset and value have to be cast, we should do that here — the original parameters should not be changed */
    if (UNEXPECTED(Z_TYPE_P(offset) != IS_STRING)) {
        ZVAL_ZVAL(&tmp, offset, 1, 0);
        convert_to_string(&tmp);
        offset = &tmp;
    }

    /* Cleanup */
    if (UNEXPECTED(offset == &tmp)) {
        zval_dtor(&tmp);
    }
}

Object handlers are set up in the constructor (https://gist.github.com/sjinks/5954372#file-test-c-L27) and during the class registration (https://gist.github.com/sjinks/5954372#file-test-c-L68)