Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T2893 logger date format #14648

Merged
merged 7 commits into from
Dec 23, 2019
Merged

T2893 logger date format #14648

merged 7 commits into from
Dec 23, 2019

Conversation

niden
Copy link
Member

@niden niden commented Dec 23, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed the logic when logging times for Phalcon\Logger to use DateTimeImmutable so as to handle microseconds if necessary.

Thanks

@niden niden added 4.0 enhancement Enhancement to the framework labels Dec 23, 2019
ruudboon
ruudboon previously approved these changes Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #14648 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14648   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files         483      483           
  Lines      111370   111370           
=======================================
  Hits        75139    75139           
  Misses      36231    36231

@niden niden merged commit 5fb4854 into phalcon:4.0.x Dec 23, 2019
@niden niden deleted the T2893-logger-date-format branch December 23, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants