Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting again interfaces and added tests #14494

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Correcting again interfaces and added tests #14494

merged 4 commits into from
Oct 28, 2019

Conversation

niden
Copy link
Member

@niden niden commented Oct 28, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed interfaces for factory, added tests

Thanks

@niden niden changed the title [4.0.x] - Correcting again interfaces and added tests [WIP] - Correcting again interfaces and added tests Oct 28, 2019
@ruudboon
Copy link
Member

@niden Running phpcbf should fix the CI build error.

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #14494 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14494      +/-   ##
==========================================
- Coverage    67.7%    67.7%   -0.01%     
==========================================
  Files         482      482              
  Lines      111384   111388       +4     
==========================================
+ Hits        75416    75418       +2     
- Misses      35968    35970       +2

@niden niden changed the title [WIP] - Correcting again interfaces and added tests Correcting again interfaces and added tests Oct 28, 2019
@niden niden merged commit 5d0c288 into phalcon:4.0.x Oct 28, 2019
@niden niden added 4.0 labels Oct 28, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants