Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type on Phalcon\Mvc\View\Engine\AbstractEngine::partial #14447

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

CameronHall
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of the change: This issue has only come up now because return types weren't being enforced in Phalcon 3.

Thanks

Phalcon\Mvc\View::partial is a void so it doesn't make sense to give this a string return type.
Updated changelog
@CameronHall CameronHall changed the title Fixed return type on Phalcon\Mvc\View\Engine\AbstractEngine Fixed return type on Phalcon\Mvc\View\Engine\AbstractEngine::partial Oct 5, 2019
@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #14447 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14447   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         482      482           
  Lines      111207   111207           
=======================================
  Hits        75304    75304           
  Misses      35903    35903

Copy link
Member

@ruudboon ruudboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time it would be nice to have a test for this also.

@niden niden added 4.0 breaks bc Functionality that breaks Backwards Compatibility labels Oct 5, 2019
@niden niden merged commit 916e6e2 into phalcon:4.0.x Oct 5, 2019
@niden
Copy link
Member

niden commented Oct 5, 2019

Thank you @CameronHall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants