Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13149 cancel on fail #14083

Merged
merged 4 commits into from
May 16, 2019
Merged

T13149 cancel on fail #14083

merged 4 commits into from
May 16, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 16, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Fixed Phalcon\Validation::validate() with cancelOnFail. The validator will validate all elements and will stop processing validators on a per element basis if cancelOnFail is present.

Thanks

@niden niden added breaks bc Functionality that breaks Backwards Compatibility Bug - High labels May 16, 2019
@niden
Copy link
Member Author

niden commented May 16, 2019

cc @sergeyklay

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #14083 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14083      +/-   ##
==========================================
+ Coverage   71.19%   71.19%   +<.01%     
==========================================
  Files         479      479              
  Lines       93869    93863       -6     
==========================================
- Hits        66826    66823       -3     
+ Misses      27043    27040       -3
Impacted Files Coverage Δ
ext/phalcon/validation.zep.c 76.96% <0%> (-0.07%) ⬇️
ext/phalcon/forms/form.zep.c 78.11% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25dafda...26f6343. Read the comment docs.

@niden niden merged commit 38e3c13 into phalcon:4.0.x May 16, 2019
@niden niden deleted the T13149-cancel-on-fail branch May 19, 2019 02:59
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants